Skip to content

Conversation

@andrei-zhidkov
Copy link
Contributor

Hey @green-coder,

Thank you so much for Girouette!

I've started using the library recently, and noticed that using divide-x class seems to produce swapped left/right border rules as compared to Tailwind.

In this MR,

  • the garden-fn for :divide-width was updated in line with Tailwind's implementation
  • the test was updated to account for the change
  • the examples for different kinds of divide-* classes were added to the example app

NB: The update to the example app also revealed that divide-x-reverse rule still might not function as expected - it seems that the rule order in the example app's generated css output causes the divide-x-10 rule to override the redefinition of --gi-divide-x-reverse variable as it does in Tailwind.
I couldn't find a way to affect the sorting of garden-fn's results, so decided to create an MR as is with a fix for divide-x only.

:border-right-width and :border-left-width were switched to match with Tailwind implementation
@green-coder green-coder merged commit 6cd448d into green-coder:master Jun 12, 2022
@green-coder
Copy link
Owner

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants